Don't use object data for layer
authorMatthias Clasen <mclasen@redhat.com>
Mon, 18 Jul 2011 03:17:38 +0000 (23:17 -0400)
committerMatthias Clasen <mclasen@redhat.com>
Mon, 18 Jul 2011 03:17:38 +0000 (23:17 -0400)
Just add a regular member in GtkWidgetAccessible for it.

gtk/a11y/gtkmenuaccessible.c
gtk/a11y/gtkmenuitemaccessible.c
gtk/a11y/gtkwidgetaccessible.c
gtk/a11y/gtkwidgetaccessible.h
gtk/a11y/gtkwindowaccessible.c

index fb4ac8b32eb6123199495ff81218e740cfc654a6..df30d987cab1a1d38c5f4b18dd32cdc25281fed2 100644 (file)
@@ -32,7 +32,7 @@ gtk_menu_accessible_initialize (AtkObject *obj,
 
   obj->role = ATK_ROLE_MENU;
 
-  _gtk_widget_accessible_set_layer (GTK_WIDGET_ACCESSIBLE (obj), ATK_LAYER_POPUP);
+  GTK_WIDGET_ACCESSIBLE (obj)->layer = ATK_LAYER_POPUP;
 }
 
 static AtkObject *
index 3345a55ed349fa17850c5931bf3a1aec91bbf1f9..57df48932c45126d3c608bf2135e7e6d0b0d95d7 100644 (file)
@@ -63,7 +63,7 @@ gtk_menu_item_accessible_initialize (AtkObject *obj,
         atk_object_set_parent (obj, gtk_widget_get_accessible (parent_widget));
     }
 
-  _gtk_widget_accessible_set_layer (GTK_WIDGET_ACCESSIBLE (obj), ATK_LAYER_POPUP);
+  GTK_WIDGET_ACCESSIBLE (obj)->layer = ATK_LAYER_POPUP;
 
   if (GTK_IS_TEAROFF_MENU_ITEM (data))
     obj->role = ATK_ROLE_TEAR_OFF_MENU_ITEM;
index c631da996ebc83d1f11cd772b8c0c96e70f8b9f0..5a1fa4f216d0fac7790ef6a8c7b696c7a4206fe4 100644 (file)
@@ -127,6 +127,7 @@ gtk_widget_accessible_initialize (AtkObject *obj,
   g_signal_connect (widget, "map", G_CALLBACK (map_cb), NULL);
   g_signal_connect (widget, "unmap", G_CALLBACK (map_cb), NULL);
 
+  GTK_WIDGET_ACCESSIBLE (obj)->layer = ATK_LAYER_WIDGET;
   obj->role = ATK_ROLE_UNKNOWN;
 }
 
@@ -620,21 +621,9 @@ gtk_widget_accessible_get_size (AtkComponent *component,
 static AtkLayer
 gtk_widget_accessible_get_layer (AtkComponent *component)
 {
-  gint layer;
+  GtkWidgetAccessible *accessible = GTK_WIDGET_ACCESSIBLE (component);
 
-  layer = GPOINTER_TO_INT (g_object_get_data (G_OBJECT (component), "atk-component-layer"));
-
-  if (layer == 0)
-    return ATK_LAYER_WIDGET;
-  else
-    return (AtkLayer) layer;
-}
-
-void
-_gtk_widget_accessible_set_layer (GtkWidgetAccessible *accessible,
-                                 AtkLayer             layer)
-{
-  g_object_set_data (G_OBJECT (accessible), "atk-component-layer", GINT_TO_POINTER (layer));
+  return accessible->layer;
 }
 
 static gboolean
index 5d78d17d21141267fba2f97a997ae2394fadaf54..3f9d4cab3ef0c037d9099d9fb3a8c1df588bf455 100644 (file)
@@ -37,6 +37,8 @@ typedef struct _GtkWidgetAccessibleClass GtkWidgetAccessibleClass;
 struct _GtkWidgetAccessible
 {
   GtkAccessible parent;
+
+  AtkLayer layer;
 };
 
 struct _GtkWidgetAccessibleClass
@@ -53,9 +55,6 @@ struct _GtkWidgetAccessibleClass
 
 GType _gtk_widget_accessible_get_type (void);
 
-void  _gtk_widget_accessible_set_layer (GtkWidgetAccessible *obj,
-                                        AtkLayer             layer);
-
 G_END_DECLS
 
 #endif /* __GTK_WIDGET_ACCESSIBLE_H__ */
index 815577bc4edf6e1f785bc0de911bb1f960ecd541..badffcee6b0c0c0aaa853a9afc362e289aee4092 100644 (file)
@@ -107,7 +107,7 @@ gtk_window_accessible_initialize (AtkObject *obj,
   ATK_OBJECT_CLASS (_gtk_window_accessible_parent_class)->initialize (obj, data);
 
   g_signal_connect (data, "window-state-event", G_CALLBACK (window_state_event_cb), NULL);
-  _gtk_widget_accessible_set_layer (GTK_WIDGET_ACCESSIBLE (obj), ATK_LAYER_WINDOW);
+  GTK_WIDGET_ACCESSIBLE (obj)->layer = ATK_LAYER_WINDOW;
 
   if (GTK_IS_FILE_CHOOSER_DIALOG (widget))
     obj->role = ATK_ROLE_FILE_CHOOSER;